feat(gamelift): add Build L2 constructs for GameLift #22313
Conversation
|
|
github-actions
bot
added
the
beginning-contributor
|
GameLift tests are passing vut there is an issue in aws-appsync package present in main branch |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
|
||
| /** | ||
| * The IAM role assumed by GameLift to access server build in S3. | ||
| * If providing a custom role, it needs to trust the GameLift service principal (gamelift.amazonaws.com) and be granted sufficient permissions. |
There was a problem hiding this comment.
Please explain to the user which permissions are sufficient.
There was a problem hiding this comment.
I have improved documentation and added a required policy sample
| } | ||
| } | ||
| this.role = props.role ?? new iam.Role(this, 'ServiceRole', { | ||
| assumedBy: new iam.ServicePrincipal('gamelift.amazonaws.com'), |
There was a problem hiding this comment.
Just to confirm: you don't need to pass any policies?
There was a problem hiding this comment.
I am granting read access to for an S3 bucket + dedicated content key on binding phase for a content (see content.ts on bind methods) but otherwise no specific needs here or any specific policy
| import { Construct } from 'constructs'; | ||
|
|
||
| /** | ||
| * Represents a server content. |
There was a problem hiding this comment.
I think you will need to provide more information about server contents. Many users start exploring the services through the CDK itself. So this is a good place to explain what kinds of files a Build needs.
There was a problem hiding this comment.
I will add information on Build class as Content will be used twice for Build and for Script resources.
|
|
||
| ### Creating a custom server build | ||
|
|
||
| Your uploaded game servers are hosted on GameLift virtual computing resources, |
There was a problem hiding this comment.
This section is about server builds, but there is no mention of anything called "build" in this paragraph.
There was a problem hiding this comment.
documentation has been updated
Improve README documentation on game Build ressource.
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Following [aws-cdk-rfcs](aws/aws-cdk-rfcs#436) I have written the first `Build` L2 resource which create a GameLift Build element based on a S3 location. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Following [aws-cdk-rfcs](aws/aws-cdk-rfcs#436) I have written the first `Build` L2 resource which create a GameLift Build element based on a S3 location. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Following aws-cdk-rfcs I have written the first
BuildL2 resource which create a GameLift Build element based on a S3 location.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license